main <- dev #420
Open
main <- dev #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for checkerboard lying on the floor
Fix start recording issue
… connected/recording.
Properly canceling and erroring trial when any of the cameras are not connected/recording.
Added sound effects when neutral finished and when recording started.
|
@antoinefalisse I have tested everything myself but I think it would be good having someone else to test it in case I forgot something before merging into main. |
|
#419 is not working in the deployed version in dev for some reason, I think it is not properly reading the audio file or properly deploying it. Edit: It is working now. The file is an ogg and this extension had to be explicitly added to the rewrites and redirects rule in amplify. |
Update dev
…ding started and recording stopped.
Added sound effects for calibration finished, neutral finished, recor…
… activate/disable.
Auditory feedback is optional now. There is a checkbox in settings to activate/disable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be deployed with: stanfordnmbl/opencap-core#231